-
Notifications
You must be signed in to change notification settings - Fork 2
New Feature: implement energy device clock synchronization #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBump integration and project versions and update dependency versions; append a new v0.58.0 entry to CHANGELOG.md. No functional code changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)custom_components/plugwise_usb/manifest.json(1 hunks)
🔇 Additional comments (1)
custom_components/plugwise_usb/manifest.json (1)
12-13: Version bump matches dependency upgrade
plugwise-usb==0.47.0ties cleanly to the integration version bump to 0.58.0—looks good.
CHANGELOG.md
Outdated
| - New Feature: implement energy device clock synchronization via plugwise_usb [v0.47.0](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0) | ||
| - Link to plugwise_usb [v0.46.1](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.46.1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix incorrect backend release link
This entry should reference the same plugwise-usb release that we just bumped to (v0.47.0). Pointing readers to v0.46.1 is misleading.
Apply this diff to correct the link:
-- Link to plugwise_usb [v0.46.1](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.46.1)
+- Link to plugwise_usb [v0.47.0](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - New Feature: implement energy device clock synchronization via plugwise_usb [v0.47.0](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0) | |
| - Link to plugwise_usb [v0.46.1](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.46.1) | |
| - New Feature: implement energy device clock synchronization via plugwise_usb [v0.47.0](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0) | |
| - Link to plugwise_usb [v0.47.0](https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0) |
🤖 Prompt for AI Agents
In CHANGELOG.md around lines 5 to 6, the second bullet incorrectly links to
plugwise_usb v0.46.1 while the entry should reference v0.47.0; update the link
target and text to point to
https://github.com/plugwise/python-plugwise-usb/releases/tag/v0.47.0 so both
bullets consistently reference v0.47.0.
|



Summary by CodeRabbit
New Features
Documentation
Chores